Skip to content

[NSCalendar] Drop needless word to match Darwin. #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[NSCalendar] Drop needless word to match Darwin. #436

wants to merge 3 commits into from

Conversation

damuellen
Copy link
Contributor

@modocache replacement for #371 please test and merge

@modocache
Copy link
Contributor

Thanks, @damuellen! Sorry for the inconvenience. Part of the trouble is that, last I checked, Foundation's repository doesn't have "please test and merge" enabled. I wonder if that's changed...

@swift-ci please test and merge

@modocache
Copy link
Contributor

Yup, sure enough, it looks like that didn't work.

@swift-ci please test

@modocache
Copy link
Contributor

Or maybe I just don't have permissions to trigger CI on this repository at all...? @parkera, could you kick this off?

@parkera
Copy link
Contributor

parkera commented Jul 8, 2016

@swift-ci please test

@parkera
Copy link
Contributor

parkera commented Jul 8, 2016

I haven't been able to get the test-and-merge thing to work either.

@modocache
Copy link
Contributor

"test and merge" is enabled on a per-repo basis -- I think only apple/swift supports it. It's not enabled for swift-corelibs-xctest, for example. The situation might be remedied with some sort of offering/bribe to @shahmishal... 😆

@parkera
Copy link
Contributor

parkera commented Jul 8, 2016

I pinged the proper authorities, hopefully we'll get it turned on soon.

@damuellen
Copy link
Contributor Author

I looked at the Foundation shipped in Xcode 8 and realised that there is another change in the api,
this is now a class var, I also overlooked a test that was added in the meantime.
I found similar changes in NSLocation for which I will create another PR.

@damuellen
Copy link
Contributor Author

@parkera I'm sorry, but somehow I managed to mix my two requests, practice makes perfect.
But I found similar changes in Thread, Host and FileManager. I could make one new PR for all,or spilt them up. What do you prefer ?

@damuellen damuellen closed this Jul 8, 2016
@parkera
Copy link
Contributor

parkera commented Jul 11, 2016

Splitting them up sounds good, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants