Fix Bugs in NSCalendar Date Calculations #44
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -422,6 +422,7 @@ static UCalendarDateFields __CFCalendarGetICUFieldCodeFromChar(char ch) { | |||
| case 'G': return UCAL_ERA; | |||
| case 'y': return UCAL_YEAR; | |||
| case 'M': return UCAL_MONTH; | |||
| case 'l': return UCAL_IS_LEAP_MONTH; | |||
There was a problem hiding this comment.
This is something we are going to have to verify since it will upstream into CoreFoundation on darwin.
|
@brownleej This looks good, once the couple of issues @phausler brought up are addressed (splitting out |
|
I ran this through the tests by manually fixing up the calendar issue and it seems we have a second issue here that causes a crash in the tests the _identifier in the calendar is null which is attempted to be released in __CFCalendarDeallocate which crashes. It might be good to address that in this as well. (not certain if that is a setup or a implementation flaw currently without further debugging) |
This was referenced Dec 7, 2015
atrick
pushed a commit
to atrick/swift-corelibs-foundation
that referenced
this pull request
Jan 12, 2021
[swiftpm] Add more tests and lightly refactor the swiftpm build system
kateinoigakukun
pushed a commit
to kateinoigakukun/swift-corelibs-foundation
that referenced
this pull request
Apr 29, 2021
…6142f411f6831e9e0932 Add a test that makes sure a static Foundation is included in toolcha…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a couple of crashers when writing tests for NSCalendar date calculations, and this PR is designed to address them.
The first crasher was in initializing an NSCalendar instance. It was attempting to compare the calendar identifiers to the kCF*Calendar constants, but that was getting routed through NSObject#isEqual, which prevented it from matching up the calendar identifiers. I was able to address this by adding an implementation of isEqual for NSString, but I don't know if this implementation is sufficient or correct, so any feedback on that would be welcome.
The second crasher was in _CFCalendarDecomposeAbsoluteTimeV, getting the value for the "leap month" component. The mapping for that component had not been defined yet.