Skip to content

Initial Implementation of Stream and NSOutputStream #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 15, 2016
Merged

Initial Implementation of Stream and NSOutputStream #443

merged 1 commit into from
Jul 15, 2016

Conversation

saiHemak
Copy link
Contributor

No description provided.

@saiHemak
Copy link
Contributor Author

This and #442 have common changes in
TestFoundation/TestNSStream.swift

TestFoundation/main.swift

Foundation/NSStream.swift

@mamabusi mamabusi mentioned this pull request Jul 11, 2016
Merged
@saiHemak
Copy link
Contributor Author

Adding TestNStream.swift to project.pbxproj has been taken care in the PR #442.

@saiHemak saiHemak changed the title Intial Implementation of Stream and NSOutputStream Initial Implementation of Stream and NSOutputStream Jul 11, 2016
phausler
phausler reviewed Jul 12, 2016
View reviewed changes
Foundation/NSStream.swift
@@ -66,11 +69,11 @@ public class Stream: NSObject {
}

public func open() {
NSUnimplemented()
streamOpen()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refer to the comment on #442 per requiring subclassers to implement these

@saiHemak
Copy link
Contributor Author

@phausler : Thanks for your review .I have addressed your comments ..Please review

@phausler
Copy link
Contributor

@swift-ci Please test

@saiHemak
Copy link
Contributor Author

I have resolved the conflicts ..

phausler
phausler reviewed Jul 14, 2016
View reviewed changes
Foundation/NSStream.swift
}

public convenience init?(toFileAtPath path: String, append shouldAppend: Bool) {
NSUnimplemented()
self.init(url: URL(fileURLWithPath: path), append: true)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why I this always appending?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified the code to pass 'shouldAppend' to self.init(url ..) which handles setting the stream property

@saiHemak
Copy link
Contributor Author

@phausler :Thanks for the review and comments.I have responded to all of them.I have also contributed tests that covers most of the contributed code.I have taken this up as a prerequisite for implementing NSJSONSerialization.writeJSONObject(toStream) .I plan to add more tests to this class at a later point in time .

@phausler
Copy link
Contributor

@swift-ci please test

@phausler phausler merged commit dc599bb into swiftlang:master Jul 15, 2016
@saiHemak saiHemak deleted the nsstream-branch branch February 28, 2017 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saiHemak @phausler