[SR-2133] archive to streams in XML, not OpenStep, format #458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
LGTM |
DaveLiu888
pushed a commit
to DaveLiu888/swift-corelibs-foundation
that referenced
this pull request
Jul 28, 2016
phausler
pushed a commit
that referenced
this pull request
Aug 4, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I have not had a chance to test this fix, I just noticed it whilst glancing through the code recently.
_writeXMLData() in NSKeyedArchiver invokes CFPropertyListWrite() with kCFPropertyListOpenStepFormat, which not only does not make sense (given the name of the calling function) but will also assert fail in CF. Presumably it should be changed to kCFPropertyListXMLFormat_v1_0.