[SE-0121] remove uses of optional comparison operators #459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
FYI for whoever works on this code, I think there might be a bug: it seems this function never actually returns nil, because it doesn't use |
|
Hi @parkera — what's the etiquette for getting stuff merged into corelibs-foundation? Is there a CI setup that can build/test for us? |
|
@swift-ci please test |
|
Same CI as the rest of swift. |
|
That file is mostly shared with the Swift overlay - does the same error exist there? |
|
It doesn't look like this method exists in the overlay. https://github.com/apple/swift/blob/eb27bb65a7c17bd9b4255baee5c4e4f9c214bde6/stdlib/public/SDK/Foundation/DateComponents.swift |
|
Thanks! |
DaveLiu888
pushed a commit
to DaveLiu888/swift-corelibs-foundation
that referenced
this pull request
Jul 28, 2016
kateinoigakukun
pushed a commit
to kateinoigakukun/swift-corelibs-foundation
that referenced
this pull request
Oct 11, 2023
[pull] swiftwasm from main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These operators will be removed as part of SE-0121 and swiftlang/swift#3637.
This use site was discovered by CI: https://ci.swift.org/job/swift-PR-Linux/2900/console