Mitigate an out-of-bounds memory read #4590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glessard
commented
May 13, 2022
| @@ -20,7 +20,7 @@ | |||
| // This file is shared between two projects: | |||
| // | |||
| // 1. https://github.com/apple/swift/tree/master/stdlib/public/Darwin/Foundation | |||
There was a problem hiding this comment.
This is no longer the case. What should we say instead?
|
@swift-ci please test |
|
@swift-ci please test |
Mitigate an oob memory read issue due to pointer conversion, by - adding overloads for `String.init?(cString:encoding:)` and `String.init?(utf8String:)` - enforcing null-termination precondition when possible - adding advisory deprecations for the obviously fixable cases - clarifying the null-termination precondition in doc-comments addresses rdar://93255079
|
Squashed to a single commit… |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mitigate an oob memory read issue due to pointer conversion, by
String.init?(cString:encoding:)andString.init?(utf8String:)A similar issue was resolved in the standard library in swiftlang/swift#42002
addresses rdar://93255079