Skip to content

[DateInterval] Fix func contains(_:) -> Bool. #4591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 7, 2022
Merged

[DateInterval] Fix func contains(_:) -> Bool. #4591

merged 2 commits into from
Jul 7, 2022

Conversation

YOCKOW
Copy link
Member

@YOCKOW YOCKOW commented May 15, 2022

Resolves #4588

@YOCKOW
Copy link
Member Author

YOCKOW commented May 15, 2022

@swift-ci Please test

@YOCKOW YOCKOW requested review from spevans and millenomi May 15, 2022 09:41
@YOCKOW
Copy link
Member Author

YOCKOW commented Jul 5, 2022

@millenomi
May I ping to request review from you?

parkera
parkera reviewed Jul 6, 2022
View reviewed changes
@YOCKOW
Copy link
Member Author

YOCKOW commented Jul 7, 2022

@swift-ci Please test

@YOCKOW YOCKOW requested a review from parkera July 7, 2022 08:26
@YOCKOW
Copy link
Member Author

YOCKOW commented Jul 7, 2022

@parkera
Thank you for your review. Tests are fixed and passed now.

@parkera parkera merged commit 18b19a5 into swiftlang:main Jul 7, 2022
@YOCKOW YOCKOW deleted the issue-4588 branch July 7, 2022 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parkera parkera parkera approved these changes

@spevans spevans Awaiting requested review from spevans

@millenomi millenomi Awaiting requested review from millenomi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DateInterval’s contains(_:) method doesn’t work
2 participants
@YOCKOW @parkera