CoreFoundation: adjust uuid.h inclusion
#4594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Swift Runtime path always uses the UUID functions from the statically linked UUID library. However, the header was only included in the non-Windows case. The latest LLVM update makes implicit declarations invalid as per the C99 standard. Adjust the inclusion path to also include `uuid.h` on Windows when building with the Swift Runtime.
|
CC: @bnbarham |
|
@swift-ci please test |
bnbarham
approved these changes
May 23, 2022
There was a problem hiding this comment.
Seems reasonable to me given the current failure on rebranch. @millenomi in case you have any opinions
|
@swift-ci please test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Swift Runtime path always uses the UUID functions from the
statically linked UUID library. However, the header was only included
in the non-Windows case. The latest LLVM update makes implicit
declarations invalid as per the C99 standard. Adjust the inclusion path
to also include
uuid.hon Windows when building with the SwiftRuntime.