[Modularization] Only include cstd headers when building CoreFoundation #4599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Including these headers results in improper modularization as both SwiftGlibc and CoreFoundation will include these headers. In particular, `in_addr` from `netinet/in.h` is currently causing issues when building on Linux in Swift rebranch.
|
@swift-ci please test |
compnerd
approved these changes
Jun 3, 2022
There was a problem hiding this comment.
Thanks! This is a good idea - Foundation already does an @_exported import Glibc so these should be provided for already via that module and be owned by that module.
Please to get @millenomi to take a look at this as well.
CC: @millenomi
xymus
approved these changes
Jun 3, 2022
|
This ended up not being a real issue after I fixed a commit in clang that was merged to next incorrectly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including these headers results in improper modularization as both
SwiftGlibc and CoreFoundation will include these headers. In particular,
in_addrfromnetinet/in.his currently causing issues when buildingon Linux in Swift rebranch.