Foundation: rework handling for ECANCELED
#4611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows does not have a proper POSIX equivalent to `ECANCELED`. The closes equivalent appears to be `WSAECANCELLED` which is a WinSock error code for a cancelled operation. The Windows Error `ERROR_CANCELLED` (0x04c7) is the ideal mapping even though the error code resides in a different domain. As long as the error code is compared via name, this should be safe.
|
@swift-ci please test |
compnerd
added a commit
to compnerd/apple-swift
that referenced
this pull request
Jul 8, 2022
|
This is Windows specific and seems to have passed the cross-repository test. I'm going to merge this for the time being as this can potentially help resolve some issues in SourceKit-LSP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows does not have a proper POSIX equivalent to
ECANCELED. Thecloses equivalent appears to be
WSAECANCELLEDwhich is a WinSock errorcode for a cancelled operation. The Windows Error
ERROR_CANCELLED(0x04c7) is the ideal mapping even though the error code resides in a
different domain. As long as the error code is compared via name, this
should be safe.