Base: add support for querying user home directory on Windows #4624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
CC: @parkera |
|
@swift-ci please test |
parkera
reviewed
Aug 16, 2022
The user profile directory is not possible to access without the user token for the `GetUserProfileDirectoryW`. Instead, we can iterate the users matching a particular filter (e.g. local users). This allows us to at least query some user home directory. Unfortunately, this would disallow querying of users from a domain controller. This resolves an immediate issue of SPM tests depending on the ability to query profile information for a user.
|
@swift-ci please test |
parkera
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user profile directory is not possible to access without the user
token for the
GetUserProfileDirectoryW. Instead, we can iterate theusers matching a particular filter (e.g. local users). This allows us
to at least query some user home directory. Unfortunately, this would
disallow querying of users from a domain controller. This resolves an
immediate issue of SPM tests depending on the ability to query profile
information for a user.