URLSessionWebSocketTask.receive() not finishing if server closes connection without a close packet

[pseligman]

Two fixes required here:

• _WebSocketURLProtocol needs to detect a closing URL connection, and set its state to indicate this is a normal close of the connection
• URLSessionWebSocketTask needs to kick doPendingWork() if the connection is closed out due to an error, in order to respond to any pending Tasks parked in receive()

[pseligman]

@jrflat could you please review?

[pseligman]

@swift-ci please test

[pseligman]

This was necessary for TestDecimal to build on macOS against the correct Foundation library. See also e9e183c#r1011034654 . I was mistaken in thinking this change was unnecessary.

[pseligman]

The macOS build failure appears unrelated to this change?

    dyld: Library not loaded: @rpath/lib_SwiftSyntaxMacros.dylib
      Referenced from: /Users/ec2-user/jenkins/workspace/swift-corelibs-foundation-PR-macOS/branch-main/build/Ninja-ReleaseAssert/toolchain-macosx-x86_64/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swiftc
      Reason: image not found

[jrflat]

Looks good!

[jrflat]

@swift-ci please test

[pseligman]

Same macOS error :-/

    dyld: Library not loaded: @rpath/lib_SwiftSyntaxMacros.dylib
      Referenced from: /Users/ec2-user/jenkins/workspace/swift-corelibs-foundation-PR-macOS/branch-main/build/Ninja-ReleaseAssert/toolchain-macosx-x86_64/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swiftc
      Reason: image not found

[jrflat]

@swift-ci please test macOS platform

[pseligman]

error: --install-xctest is not supported on this platform

Seems the macOS platform build is still having issues unrelated to this change?

[jrflat]

@swift-ci please test macOS platform

[pseligman]

error: --install-xctest is not supported on this platform same issue as last week

[jrflat]

@swift-ci please test macOS platform

[jrflat]

Tests look good!