Foundation: attempt a first pass symlink resolution #4681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, rather than recursively expanding a path component by component, perform a first pass resolution at the given path. This potentially influences the path resolution as the component traversal would possibly fail to resolve cross-drive references.
|
CC: @parkera |
|
@swift-ci please test |
parkera
approved these changes
Jan 3, 2023
|
@parkera I think it could be nice to do that, but I didn't want to put in the effort if this code path is unlikely to survive the rewrite of Foundation. This was something that I ran across when getting the SourceKit-LSP tests resolved, so it is definitely something we hit. The one thing that I worry about a test case for this is that it will potentially require running with elevated privileges (i.e. as "root") to create the symbolic links to traverse. However, if we have existing test cases which do that and are passing, we should be able to accommodate that. |
|
@swift-ci please test macOS platform |
|
Ok, that makes sense. LGTM then and thank you. |
|
@swift-ci please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, rather than recursively expanding a path component by component, perform a first pass resolution at the given path. This potentially influences the path resolution as the component traversal would possibly fail to resolve cross-drive references.