change FileManager.default() class function to static let #484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. |
|
@swift-ci please test |
|
@jpsim This needs rebasing. |
jpsim
force-pushed
the
filemanager-default
branch
from
af1f082 to
c5e4e6b
Compare
|
rebased |
|
@swift-ci please test. |
|
@jpsim Looks like you missed something in |
|
Indeed. Fixed. |
|
Once more, with feeling. @swift-ci please test. |
jpsim
added a commit
to jpsim/swift-package-manager
that referenced
this pull request
Aug 1, 2016
…rsion this PR should be merged with swiftlang/swift-corelibs-foundation#484
|
This should be merged with swiftlang/swift-package-manager#584 |
|
Unfortunately this has been conflicted... @jpsim I can shepherd landing this (swift-ci can't handle multi-repo PRs yet) if someone rebases it. |
jpsim
force-pushed
the
filemanager-default
branch
from
ee5bb25 to
df452e8
Compare
|
@ddunbar rebased again 😅 |
|
Thanks, testing now... |
|
Merged, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to match Darwin version as of Xcode 8