Skip to content

Updates for SE-0110 Part I #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2016
Merged

Updates for SE-0110 Part I #497

merged 1 commit into from
Jul 31, 2016

Conversation

dduan
Copy link
Contributor

@dduan dduan commented Jul 31, 2016

For more information, see swiftlang/swift#3895

@CodaFi
Copy link
Contributor

CodaFi commented Jul 31, 2016

Confirming the NFC-ness of this change on my machine. In the meantime can you squash this?

@dduan
Copy link
Contributor Author

dduan commented Jul 31, 2016

@CodaFi squashed. Good to merge?

@dduan
Copy link
Contributor Author

dduan commented Jul 31, 2016

Or should we wait for all dependencies to be verified to minimize the impact?

@CodaFi
Copy link
Contributor

CodaFi commented Jul 31, 2016

Because all of these patches are NFC I think they can go in as fast as you can serve them. I have a machine setup where I'm going to keep rebasing onto these branches as you submit them and in the end I'm going to rebase onto the swift changes and run the whole thing.

@CodaFi
Copy link
Contributor

CodaFi commented Jul 31, 2016

@swift-ci please test.

@CodaFi
Copy link
Contributor

CodaFi commented Jul 31, 2016

🎆

@CodaFi CodaFi merged commit a0a8da3 into swiftlang:master Jul 31, 2016
kateinoigakukun pushed a commit to kateinoigakukun/swift-corelibs-foundation that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants