Mechanically add 'open' to all public classes. #499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This applies 'open' to all public classes and all of their non-final
public methods, properties, and subscripts, preserving the existing
behavior when SE-0117 is implemented. This transformation was performed
mechanically using the following sed script (run with sed -E):
/(init|mutating|struct|enum|typealias|final|let|static)/ {
p
d
}
/public class/,/^}/ s/public/open/
This should probably be refined soon, but for now this allows us to
implement SE-0117 without immediately requiring updates in all
clients. Specifically, there are two areas where this change may not
be correct to match Foundation on Apple platforms:
- Members in extensions cannot yet be overridden, so none of them have
been marked 'open'.
- Some classes are /not/ intended to be overridden, even in Objective-C.
Specifying this requires input from the Foundation team.
Groundwork for SE-0117 "Allow distinguishing between public access and
public overridability"
|
@swift-ci Please test |
|
Ah, this may not work without swiftlang/swift-corelibs-xctest#150. |
|
I've pulled the xctest change, so we'll just merge this as well. Thanks! |
kateinoigakukun
pushed a commit
to kateinoigakukun/swift-corelibs-foundation
that referenced
this pull request
Oct 11, 2023
[pull] swiftwasm from main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies
opento all public classes and all of their non-final public methods, properties, and subscripts, preserving the existing behavior when SE-0117 is implemented. This transformation was performed mechanically using the following sed script (run withsed -E):This should probably be refined soon, but for now this allows us to implement SE-0117 without immediately requiring updates in all clients. Specifically, there are two areas where this change may not be correct to match Foundation on Apple platforms:
open.Groundwork for SE-0117 "Allow distinguishing between public access and public overridability"