Key visibility #502
Merged
Key visibility #502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @parkera |
|
@swift-ci please test |
| @@ -41,7 +41,7 @@ typedef CF_ENUM(CFIndex, CFDateFormatterAmbiguousYearHandling) { | |||
|
|
|||
| extern UCalendar *__CFCalendarCreateUCalendar(CFStringRef calendarID, CFStringRef localeID, CFTimeZoneRef tz); | |||
|
|
|||
| static CONST_STRING_DECL(kCFDateFormatterFormattingContextKey, "kCFDateFormatterFormattingContextKey"); | |||
| CONST_STRING_DECL(kCFDateFormatterFormattingContextKey, "kCFDateFormatterFormattingContextKey"); | |||
There was a problem hiding this comment.
Was this meant to switch to the PE version as below? Otherwise, why remove the static?
There was a problem hiding this comment.
I noticed that they were used with externally visible functions, so it seems that the key could be used externally.
There was a problem hiding this comment.
Sometimes these are used with the same functions but only meant to be used internally to CF.
|
ping? CC: @phausler |
Use the private extern version of the constnat string macro. This allows for the constnat string macro to be used for defining keys which are exported. It also avoids having two different copies of the keys which are used independently based on the compiler version.
These are not meant to be internal, but mixing the static here would prevent the key from being defined on COFF targets which use dllexport semantics which require that the symbol have external visibility.
compnerd
force-pushed
the
key-visibility
branch
from
11c30a3 to
590b830
Compare
|
@swift-ci please test |
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.