Skip to content

Swift 3: Value Types and Naming #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 10, 2016
Merged

Swift 3: Value Types and Naming #508

merged 4 commits into from
Aug 10, 2016

Conversation

michael-lehew
Copy link
Contributor

Does the following:

  1. brings AffineTransform value type over (changing name of previous struct)
  2. de-NS's NSAffineTransform
  3. apply new naming guidelines to NSAffineTransform
  4. add hash tests
  5. profit

@michael-lehew
Copy link
Contributor Author

@swift-ci please test linux

@michael-lehew michael-lehew changed the title Swift 3: AffineTransform value type and naming Swift 3: Value Types and Naming Aug 9, 2016
@michael-lehew michael-lehew merged commit f2a3cb1 into swiftlang:master Aug 10, 2016
@jrose-apple
Copy link
Contributor

jrose-apple commented Aug 11, 2016

CharacterSet changes snuck in here which broke things:

Foundation/CharacterSet.swift:58:18: error: method does not override any method from its superclass
   override func copy(with zone: NSZone? = nil) -> AnyObject {
                 ^
Foundation/NSCharacterSet.swift:197:15: note: potential overridden instance method 'copy(with:)' here
    open func copy(with zone: NSZone? = nil) -> Any {
              ^
Foundation/CharacterSet.swift:62:19: error: method does not override any method from its superclass
    override func mutableCopy(with zone: NSZone? = nil) ->  AnyObject {
                  ^
Foundation/NSCharacterSet.swift:211:15: note: potential overridden instance method 'mutableCopy(with:)' here
    open func mutableCopy(with zone: NSZone? = nil) -> Any {
              ^

I'm going to revert to get the Linux bots blue again.

jrose-apple added a commit that referenced this pull request Aug 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants