[SR-71] Repair NSNumber behaviour #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During initalization store the number type in the CFInfo bitfield in the same way that CFNumberCreate does. NSNumber/CFNumber stores its value in a UInt64 (_pad) with associated type information as part of the CFInfo bitfield. NSNUmber Initialization is performed through _CFNumberInit which copies the value bytes into _pad but does not store the type information. This leads to broken behaviour when converting between type repesentations. i.e. Double -> NSNumber -> Integer.
|
Looks great, thanks. |
parkera
added a commit
that referenced
this pull request
Dec 6, 2015
[SR-71] Repair NSNumber behaviour
atrick
pushed a commit
to atrick/swift-corelibs-foundation
that referenced
this pull request
Jan 12, 2021
Remove extra spaces before func.
kateinoigakukun
pushed a commit
to kateinoigakukun/swift-corelibs-foundation
that referenced
this pull request
Apr 29, 2021
Update swift-package tests from Compile -> Compiling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During initalization store the number type in the CFInfo bitfield in the
same way that CFNumberCreate does.
NSNumber/CFNumber stores its value in a UInt64 (_pad) with associated type
information as part of the CFInfo bitfield. NSNUmber Initialization is
performed through _CFNumberInit which copies the value bytes into _pad but
does not store the type information. This leads to broken behaviour when
converting between type repesentations. i.e. Double -> NSNumber ->
Integer.
Fixes: https://bugs.swift.org/browse/SR-71