Fix CoreFoundation standalone build syntax errors #543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can insert |
|
@CodaFi oh thanks! that did it. Should I submit a separate pull request to fix that? |
|
Naw, this one works just fine. |
Not sure how these trailing quotes crept in, but the file doesn't parse unless you remove them. The build also fails without CFAsmMacros.h in scope, so I added that to the private headers list.
|
@CodaFi done 😄 thanks again! |
|
I've verified that this fix builds locally on OS X and Linux. Merging. |
|
Awesome, thanks for the cleanup! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how these trailing quotes crept in, but the file doesn't parse unless you remove them.
Also, the standalone build still doesn't work for me unless I add some hackery to bring<CoreFoundation/CFAsmMacros.h>into the search path. I've worked around it in my build but I don't know what the proper solution is so I'm only including the syntax fixes until that's sorted out.Edit: This PR now also fixes the CFAsmMacros.h issue.
cc @phausler @CodaFi