Skip to content

enable Dispatch tests in TestNSOperationQueue #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2016
Merged

enable Dispatch tests in TestNSOperationQueue #559

merged 1 commit into from
Aug 22, 2016

Conversation

dgrove-oss
Copy link
Contributor

After you merge #551 and Dispatch is enabled by default, both of these tests will now pass and can be enabled.

@parkera
Copy link
Contributor

parkera commented Aug 20, 2016

Alright, so dispatch should be enabled now. Let's try it out by testing this PR.

@parkera
Copy link
Contributor

parkera commented Aug 20, 2016

@swift-ci please test linux

@parkera
Copy link
Contributor

parkera commented Aug 20, 2016

Good news - it built! Bad news - it failed.

Test Suite 'TestNSOperationQueue' started at 06:08:24.096
Test Case 'TestNSOperationQueue.test_OperationPriorities' started at 06:08:24.096
fatal error: Index out of range: file /home/buildnode/disk2/workspace/swift-corelibs-foundation-PR-Linux/swift/stdlib/public/core/ContiguousArrayBuffer.swift, line 366
Current stack trace:
0    libswiftCore.so                    0x00007f23921ca250 swift_reportError + 117

@seabaylea
Copy link
Contributor

@parkera Looks like the CI ran whilst it still wasn't configured to build libdispatch - the build configuration written to the log contains:

--skip-build-libdispatch

Testing locally with the latest master, this works for me. Could you try re-running the CI test?

@parkera
Copy link
Contributor

parkera commented Aug 22, 2016

@swift-ci please test linux

@parkera
Copy link
Contributor

parkera commented Aug 22, 2016

Sure thing

@parkera
Copy link
Contributor

parkera commented Aug 22, 2016

Passed!

@parkera parkera merged commit f8c3fe6 into swiftlang:master Aug 22, 2016
@dgrove-oss dgrove-oss deleted the nsoperationqueue-tests branch August 23, 2016 11:52
kateinoigakukun added a commit to kateinoigakukun/swift-corelibs-foundation that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants