Implement -[NSData writeToURL:options:error:] #57
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,10 +9,10 @@ | |
|
|
||
|
|
||
| /*************** Exceptions ***********/ | ||
| public let NSDecimalNumberExactnessException: String = "NSDecimalNumberExactnessException" | ||
| public let NSDecimalNumberOverflowException: String = "NSDecimalNumberOverflowException" | ||
| public let NSDecimalNumberUnderflowException: String = "NSDecimalNumberUnderflowException" | ||
| public let NSDecimalNumberDivideByZeroException: String = "NSDecimalNumberDivideByZeroException" | ||
|
There was a problem hiding this comment. These are not exactly part of NSData's url writing, it would be good to split them out to their own commits There was a problem hiding this comment. This and the one below |
||
|
|
||
| /*************** Rounding and Exception behavior ***********/ | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| // This source file is part of the Swift.org open source project | ||
| // | ||
| // Copyright (c) 2014 - 2015 Apple Inc. and the Swift project authors | ||
| // Licensed under Apache License v2.0 with Runtime Library Exception | ||
| // | ||
| // See http://swift.org/LICENSE.txt for license information | ||
| // See http://swift.org/CONTRIBUTORS.txt for the list of Swift project authors | ||
| // | ||
|
|
||
|
|
||
|
|
||
| #if DEPLOYMENT_RUNTIME_OBJC || os(Linux) | ||
| import Foundation | ||
| import XCTest | ||
| #else | ||
| import SwiftFoundation | ||
| import SwiftXCTest | ||
| #endif | ||
|
|
||
|
|
||
|
|
||
| class TestNSData : XCTestCase { | ||
|
|
||
| var allTests : [(String, () -> ())] { | ||
| return [ | ||
| ("test_writeToURLOptions", test_writeToURLOptions) | ||
| ] | ||
| } | ||
|
|
||
| func test_writeToURLOptions() { | ||
| let saveData = NSData(contentsOfURL: NSBundle.mainBundle().URLForResource("Test", withExtension: "plist")!) | ||
| let savePath = "/var/tmp/Test.plist" | ||
| do { | ||
| try saveData!.writeToFile(savePath, options: NSDataWritingOptions.DataWritingAtomic) | ||
| let fileManager = NSFileManager.defaultManager() | ||
| XCTAssertTrue(fileManager.fileExistsAtPath(savePath)) | ||
| try! fileManager.removeItemAtPath(savePath) | ||
| } catch let error { | ||
| XCTFail((error as! NSError).localizedDescription) | ||
| } | ||
| } | ||
| } | ||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -33,4 +33,5 @@ XCTMain([ | |
| TestNSFileManger(), | ||
| TestNSRange(), | ||
| TestNSXMLParser(), | ||
| TestNSData() | ||
| ]) | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to me that the error message also isn't quite correct about the first part. You aren't checking whether a folder exist, but wether the URL given contains a path. (But I am not sure exactly what the existing Foundation framework does/reports in this case.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the url is a file url then it checks to see if the url has a path, if it does not it claims there is no such file (which is kind-of true-ish)
then it will funnel to writeToFile in the case of a file url (which has it's own error cases)
else it claims the url is an unsupported scheme.