Make Darwin targets buildable after merge #586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o the project were introduced from URLSession
|
@swift-ci Please test |
| } | ||
| } | ||
|
|
||
| fileprivate extension URLSessionTask._EasyHandle { |
There was a problem hiding this comment.
Note: this pattern causes build failures on Darwin with the latest binary toolchain drops.
We cannot adopt this until the toolchain revs to contain this.
There was a problem hiding this comment.
Does the Swift 3.0 toolchain have it or is it only on master?
There was a problem hiding this comment.
I believe it is only master. However I could be mistaken.
kateinoigakukun
added a commit
to kateinoigakukun/swift-corelibs-foundation
that referenced
this pull request
Oct 11, 2023
[pull] swiftwasm from main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
un-buildable changes were pushed to the project were introduced from URLSession. This broke the builds for Darwin hosts since the Xcode project could no longer build. This adds the URLSession and associated files in as per required for the Xcode project, links libcurl, and renames the nested class which does not work on the latest binary drop of the swift toolchain (the support for which is still pending on master)