Swift 3 API parity for [NS]TimeZone & [NS]Calendar #609
Conversation
|
@swift-ci Please test |
|
This failure is unrelated to these changes. I think something is going on with CI ATM — we had a separate, spurious build failure in CI a few minutes ago that seemed related to a configuration issue |
|
Going to try again soon |
| @@ -249,3 +292,7 @@ extension NSTimeZone { | |||
| } | |||
|
|
|||
| } | |||
|
|
|||
| extension NSNotification.Name { | |||
| public static let NSSystemTimeZoneDidChange = NSNotification.Name(rawValue: "NSSystemTimeZoneDidChangeNotification") // NSUnimplemented | |||
There was a problem hiding this comment.
@itaiferber, could you do me a favor and remove the raw value from this line? I think it's not supposed to be here (my mistake!). I'll create a PR to have it removed from master as well.
There was a problem hiding this comment.
@xwu As in, the string value itself, or rawValue:?
There was a problem hiding this comment.
As in make it read public static let NSSystemTimeZoneDidChange = NSNotification.Name(rawValue: ""), since that seems to be what the project does for these.
There was a problem hiding this comment.
@xwu No problem. I'm just going to let this CI pass run first before pushing the changes.
|
@swift-ci Please test |
|
CI fails when trying to |
|
CI job fixed and passed here |
Pulls #602 and #608 into swift-3.0-branch