Tests for TimeZone.localizedName #612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| func test_localizedName(){ | ||
| let initialTimeZone = NSTimeZone.default | ||
| NSTimeZone.default = TimeZone(identifier: "America/New_York")! | ||
| let defaultTimezone = NSTimeZone.default |
There was a problem hiding this comment.
Nit: for consistent capitalization, this should be defaultTimeZone
| @@ -117,6 +117,20 @@ class TestNSTimeZone: XCTestCase { | |||
| let known = NSTimeZone.knownTimeZoneNames | |||
| XCTAssertNotEqual([], known, "known time zone names not expected to be empty") | |||
| } | |||
|
|
|||
| func test_localizedName(){ | |||
There was a problem hiding this comment.
I've got a few nits myself before I'm ready to merge, if you don't mind. test_localizedName(){ → test_localizedName() {
saiHemak
force-pushed
the
nstimezone-branch
branch
from
c788327 to
8e435a0
Compare
|
@itaiferber Thanks for the review.I have addressed your comments .. |
|
Looks good to me! |
|
@swift-ci Please test |
|
@parkera Should this be submitted against swift-3.0-branch? |
|
Let's leave it on master; no need for pure testing code on the swift 3 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.