Contributing test-cases for NSOperation/NSOperationQueue. #617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| msgOperations.append("Operation1 executed") | ||
| sleep(1) |
There was a problem hiding this comment.
Added time-lag to resolve the test-case failures seen sometimes on TestFoundation.
There was a problem hiding this comment.
Sorry - sleep cannot be a fix for issues like this. Instead we should use a semaphore to signal completion of whatever work we are waiting on.
There was a problem hiding this comment.
Ok. Will modify to use semaphores. Thank you.
|
The test is correct and exposed a real bug in the underlying concurrency code that is fixed by #621. This PR is not needed now and can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.