Implementation for NSDictionary.write(toFile:) #627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saiHemak
force-pushed
the
nsdictWriteTo-branch
branch
from
9b88e78 to
a81cb15
Compare
| let pListData = try PropertyListSerialization.data(fromPropertyList: self, format: PropertyListSerialization.PropertyListFormat.xml, options: 0) | ||
| let xmlDocument = try XMLDocument.init(data: pListData, options: XMLNode.Options.documentValidate) | ||
| let xmlData = xmlDocument.xmlData(withOptions: XMLNode.Options.nodePrettyPrint) | ||
| try xmlData.write(to: URL(fileURLWithPath: path), options: useAuxiliaryFile ? .atomic : []) |
There was a problem hiding this comment.
I think we should skip this XMLDocument step. Here is the ObjC implementation:
NSData *data = [NSPropertyListSerialization dataWithPropertyList:self format:NSPropertyListXMLFormat_v1_0 options:0 error:NULL];
BOOL result = [data writeToFile:path atomically:useAuxiliaryFile];
return result;
saiHemak
force-pushed
the
nsdictWriteTo-branch
branch
from
a81cb15 to
d47db67
Compare
|
@parkera Thanks for the review ..I have addressed your comments |
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.