[swift-3.0-branch] Fix crash in NSValue.isEqual() when it is passed an NSNumber #634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng#619) NSNumbers are not added to the side table, so we can't find them.
|
@swift-ci please test |
|
This is up to @parkera to approve. |
|
Even though swiftlang/swift#4753 does not get pulled in the release, I believe this PR qualifies as a bug fix, so is still worth merging. |
parkera
requested changes
Sep 15, 2016
| var long: Int32 = 123456 | ||
| let value = NSValue(bytes: &long, objCType: "l") | ||
| XCTAssertFalse(value.isEqual(number)) | ||
| } |
There was a problem hiding this comment.
Can we add a positive-sense test here as well?
|
Not going to merge. See explanation here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://problem/28284641