SR-2683 URLSessionDelegate didCompleteWithError callback never triggered #636
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SR-2638 reports that the following URLSessionDelegate callback is never triggered:
This is actually caused by a function signature issue - I'm not sure why the compiler isn't picking it up.
On Linux, the function signature for the callback is currently using the old style:
ie. its specified as an
NSError
instead ofError
.This PR switches over the API, and coerces the
NSError
to anError
before calling the callback.