Skip to content

Implemented setLocalizedDateFormatFromTemplate #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 21, 2016
Merged

Implemented setLocalizedDateFormatFromTemplate #671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
db443a1
Implemented setLocalizedDateFormatFromTemplate
JGiola Oct 6, 2016
73b8d2f
Change locale
JGiola Oct 18, 2016
3a827f4
Add test case
JGiola Oct 18, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Foundation/NSDateFormatter.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,9 @@ open class DateFormatter : Formatter {
}

open func setLocalizedDateFormatFromTemplate(_ dateFormatTemplate: String) {
NSUnimplemented()
if let format = DateFormatter.dateFormat(fromTemplate: dateFormatTemplate, options: 0, locale: locale) {
dateFormat = format
}
}

private func _reset() {
Expand Down
17 changes: 15 additions & 2 deletions TestFoundation/TestNSDateFormatter.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ class TestNSDateFormatter: XCTestCase {
("test_dateStyleMedium", test_dateStyleMedium),
("test_dateStyleLong", test_dateStyleLong),
("test_dateStyleFull", test_dateStyleFull),
("test_customDateFormat", test_customDateFormat)
("test_customDateFormat", test_customDateFormat),
("test_setLocalizedDateFormatFromTemplate", test_setLocalizedDateFormatFromTemplate),
]
}

Expand Down Expand Up @@ -277,5 +278,17 @@ class TestNSDateFormatter: XCTestCase {
XCTAssertEqual(f.string(from: testDate), "11-03-2016")

}


func test_setLocalizedDateFormatFromTemplate() {
let locale = Locale(identifier: DEFAULT_LOCALE)
let template = "EEEE MMMM d y hhmmss a zzzz"

let f = DateFormatter()
f.locale = locale
f.setLocalizedDateFormatFromTemplate(template)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the benefit of calling f.setLocalizedDateFormatFromTemplate(template) over doing
f.dateFormat = DateFormatter.dateFormat(fromTemplate: dateFormatTemplate, options: 0, locale: locale)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, here I have to test that the setLocalizedDataFormatFromTemplate will generate the same format as DateFormatter.dateFormat(fromTemplate: dateFormatTemplate, options: 0, locale: locale) if I call directly the latter how can I test it?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not what I meant - though I can see how the placement of this comment made my intent misleading.

I actually meant this as a comment about the entire pull request. I don't really see the added benefit of adding a method like setLocalizedDateFormatFromTemplate() especially when you can just call f.dateFormat = DateFormatter.dateFormat(fromTemplate: dateFormatTemplate, options: 0, locale: locale).

Copy link
Contributor Author

@JGiola JGiola Dec 21, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, right, my bad :)
Maybe you have to ask this question to the Foundation guys inside Cupertino, I merely implement it for removing the NSUnimplemented() call, is a new API added in iOS 10 or 9 if I'm not mistaken

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am one of the Foundation "guys" 😉. Looking at the implementation of the obj-c version of this method, the method essentially is meant to be purely a convenience so what you've implemented here is fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will write here because it seems the correct place, I'm sorry for all the people who are working on Foundation and on every other project around the world to have used the term "guys" for reference the group working on Foundation. There are many words to indicate a group of people (like, you know "people") and I'm very sorry to have choose and write the less inclusive of all, I would like to apologise to every person who have read my comment. Please forgive me, and keep up with your amazing work.


let dateFormat = DateFormatter.dateFormat(fromTemplate: template, options: 0, locale: locale)
XCTAssertEqual(f.dateFormat, dateFormat)
}

}