Add support for ISO8601 calendar and others #677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The list of valid keys did not include the ISO8601 calendar, which meant that code running on Linux that used it would fail. Fix this by adding the kCFISO8601Calendar and others into the list of known constants valid for calendars, and add tests for the Gregorian calendar, as well as for creating all other calendars. Issue: SR-2551
|
@swift-ci please test |
|
Ack. Hit the wrong button. =) |
|
Yeah I did that with the other pull request accidentally as well :-) Still, at least the tests worked out this time. |
|
Thanks! |
parkera
pushed a commit
that referenced
this pull request
Oct 13, 2016
* Retain localeID when constructing a Calendar The Calendar destructor releases stored values when the Calendar is being deallocated, including releasing the localeID. By default this is an empty string (kCFEmptyString) which results in multiple Calendars causing a fault when it is over-released. Ensure that instead the localeID is retained to balance the release when it is cleaned up. Issue: SR-2879 * Add support for ISO8601 calendar and others (#677) The list of valid keys did not include the ISO8601 calendar, which meant that code running on Linux that used it would fail. Fix this by adding the kCFISO8601Calendar and others into the list of known constants valid for calendars, and add tests for the Gregorian calendar, as well as for creating all other calendars. Issue: SR-2551
pushkarnk
pushed a commit
to pushkarnk/swift-corelibs-foundation
that referenced
this pull request
Oct 17, 2016
The list of valid keys did not include the ISO8601 calendar, which meant that code running on Linux that used it would fail. Fix this by adding the kCFISO8601Calendar and others into the list of known constants valid for calendars, and add tests for the Gregorian calendar, as well as for creating all other calendars. Issue: SR-2551
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list of valid keys did not include the ISO8601 calendar, which
meant that code running on Linux that used it would fail. Fix this
by adding the kCFISO8601Calendar and others into the list of known
constants valid for calendars, and add tests for the Gregorian
calendar, as well as for creating all other calendars.
Issue: SR-2551