NSCopying for NSDictionary #68
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } else if self.dynamicType === NSMutableDictionary.self { | ||
| // Otherwise, create a new NSDictionary object | ||
|
|
||
| // TODO: speed up? |
There was a problem hiding this comment.
technically you could create a NSDictionary by returning one created via the storage directly.
As suggested by @phausler.
| // Otherwise, create a new NSDictionary object | ||
|
|
||
| let newDict = NSDictionary() | ||
| newDict._storage = _storage |
There was a problem hiding this comment.
generally I would prefer a better isolation of control however the compiler has some issues with NSDictionary.init(dictionary: [NSObject, AnyObject])
|
the change looks good however this is causing a crash in the compiler for me |
|
This functionality has been merged in already that did not have the compiler crashes. |
atrick
pushed a commit
to atrick/swift-corelibs-foundation
that referenced
this pull request
Jan 12, 2021
Completion item returns type name in details
kateinoigakukun
pushed a commit
to kateinoigakukun/swift-corelibs-foundation
that referenced
this pull request
Apr 29, 2021
[XFail] Test LLDBB with SwiftPM (56054057)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements
NSCopyingandNSMutableCopyingprotocols inNSDictionary, as well as creating a couple of test methods for verifying the behavior of the copy methods.