Final implementation of Decimal #687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This extends the normalisation routines to be able to handle mismatched size elements, and division of decimals that are larger than short values correctly. It adds tests that are the same coverage as for NSDecimal on Darwin.
Using the functionality in NSDecimal, implement the NSDecimalNumber such that the additional tests in TestNSDecimal pass.
alblue
commented
Oct 14, 2016
| @@ -1479,26 +1566,6 @@ fileprivate struct WideDecimal : VariableLengthNumber { | |||
| } | |||
| } | |||
| } | |||
| public func compare(to rhs: WideDecimal) -> ComparisonResult { | |||
There was a problem hiding this comment.
This was added as part of a transitional implementation in the previous commit, but is no longer necessary - so it has been removed.
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the normalisation routines to be able to handle
mismatched size elements, and division of decimals that are larger
than short values correctly. It adds tests that are the same coverage
as for NSDecimal on Darwin.