basic implementation for NSURLResponse init and tests #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cullenbmacdonald
force-pushed
the
implement-nsurlresponse
branch
6 times, most recently
from
a0fe3f0 to
568b75a
Compare
|
Does this look ok or should we swap the interface to use |
cullenbmacdonald
force-pushed
the
implement-nsurlresponse
branch
4 times, most recently
from
8b55c4a to
7d5e97a
Compare
cullenbmacdonald
force-pushed
the
implement-nsurlresponse
branch
from
7d5e97a to
32bd019
Compare
|
looks good to me; after seeing the style of public private(set), I think perhaps it might be something we should adopt in places that don't have side effects or locks instead of using ivars |
|
Cool. So are you saying that this is the right implementation here? |
|
yea - it seems like a pretty reasonable pattern in many cases (not just this one) |
phausler
added a commit
that referenced
this pull request
Dec 9, 2015
basic implementation for NSURLResponse init and tests
atrick
pushed a commit
to atrick/swift-corelibs-foundation
that referenced
this pull request
Jan 12, 2021
[build-script] Add build-script-helper.py
kateinoigakukun
pushed a commit
to kateinoigakukun/swift-corelibs-foundation
that referenced
this pull request
Apr 29, 2021
add a test case for an invalid optimization
kateinoigakukun
pushed a commit
to kateinoigakukun/swift-corelibs-foundation
that referenced
this pull request
Oct 11, 2023
[pull] swiftwasm from master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.