NSPredicate partial implementation #716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkera
reviewed
Nov 15, 2016
| switch (other.kind, self.kind) { | ||
| case (.boolean(let otherBool), .boolean(let selfBool)): | ||
| return otherBool == selfBool | ||
| // TODO: case for init(format:argumentArray:) |
There was a problem hiding this comment.
Should we continue to represent these TODOs as NSUnimplemented?
There was a problem hiding this comment.
This would require implementing cases for format:argumentArray: and fromMetadataQueryString: in NSPredicate. If it's not an issue, then TODOs can be switched with NSUnimplemented. It'll also be more obvious for future implementation of missing functionality.
…TODO with NSUnimplemented.
|
@swift-ci please test and merge |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation and test for
NSPredicate'sNSCoding,NSCopying.Additionally implemented
.predicateFormat