Skip to content

Implement attributes enumerating in NSAttributedString #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 30, 2016
Merged

Implement attributes enumerating in NSAttributedString #726

merged 7 commits into from
Nov 30, 2016

Conversation

eyeplum
Copy link
Contributor

@eyeplum eyeplum commented Nov 29, 2016

This pull request implements the following NSAttributedString methods:

  • enumerateAttribute(_:in:options:using:)
  • enumerateAttributes(in:options:using:)

@parkera
Copy link
Contributor

parkera commented Nov 29, 2016

Cool, thanks.

@parkera
Copy link
Contributor

parkera commented Nov 29, 2016

@swift-ci please test and merge

- Abstract some methods to describe datas in test cases
- Always sort the mapped array of the `attrs` dictionary to make sure the result description string is stable
@eyeplum
Copy link
Contributor Author

eyeplum commented Nov 30, 2016

Hi @parkera, there was an issue in the test case.
It has been fixed. Can we try again?
Thanks.

@parkera
Copy link
Contributor

parkera commented Nov 30, 2016

@swift-ci please test and merge

@swift-ci swift-ci merged commit 5f86566 into swiftlang:master Nov 30, 2016
@naithar naithar mentioned this pull request Jan 20, 2017
@eyeplum eyeplum deleted the attributedstring branch January 24, 2017 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants