Skip to content

Add @_versioned attribute to _MutableHandle._pointer #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 17, 2017
Merged

Add @_versioned attribute to _MutableHandle._pointer #785

merged 2 commits into from
Jan 17, 2017

Conversation

ikesyo
Copy link
Member

@ikesyo ikesyo commented Jan 11, 2017 •
edited
Loading

@ikesyo ikesyo mentioned this pull request Jan 12, 2017
Merged
4 tasks
@parkera
Copy link
Contributor

parkera commented Jan 12, 2017

Hm, am I wrong or did we remove the need for Boxing.swift completely from the overlay code?

@ikesyo ikesyo force-pushed the more-versioned-attribute branch from d411bd4 to a16f1d5 Compare January 12, 2017 18:10
@briancroom
Copy link
Contributor

@parkera would you be ok merging this as-is if the CI build passes, and looking into removing the need for the file in a later PR? The issue @ikesyo mentioned is causing problems for the XCTest macOS CI job.

@briancroom
Copy link
Contributor

@swift-ci please test

@parkera
Copy link
Contributor

parkera commented Jan 13, 2017

Ok

@parkera
Copy link
Contributor

parkera commented Jan 13, 2017

@swift-ci please test and merge

1 similar comment
@briancroom
Copy link
Contributor

@swift-ci please test and merge

@briancroom
Copy link
Contributor

@ikesyo it looks like this change isn't going to work as-is:

Foundation/Boxing.swift:17:5: error: '@_versioned' attribute can only be applied to internal declarations, but '_pointer' is fileprivate
    @_versioned fileprivate var _pointer : MutableType
    ^~~~~~~~~~~~

@ikesyo ikesyo force-pushed the more-versioned-attribute branch from a16f1d5 to 3aabaa4 Compare January 14, 2017 02:09
@ikesyo
Copy link
Member Author

ikesyo commented Jan 14, 2017

@briancroom Sorry for the trouble. I've just made it internal.

@briancroom
Copy link
Contributor

@swift-ci please test

@ikesyo
Copy link
Member Author

ikesyo commented Jan 16, 2017

The test has passed https://ci.swift.org/job/swift-corelibs-foundation-PR-Linux/539/

@modocache modocache mentioned this pull request Jan 16, 2017
Merged
@ikesyo ikesyo force-pushed the more-versioned-attribute branch from 3aabaa4 to 6771721 Compare January 16, 2017 23:37
@parkera
Copy link
Contributor

parkera commented Jan 17, 2017

@swift-ci please test and merge

@swift-ci swift-ci merged commit 45b8b70 into swiftlang:master Jan 17, 2017
@ikesyo ikesyo deleted the more-versioned-attribute branch January 17, 2017 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ikesyo @parkera @briancroom @swift-ci