Skip to content

[NSAffineTransform] NSCoding implementation #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 2, 2017
Merged

[NSAffineTransform] NSCoding implementation #815

merged 4 commits into from
Feb 2, 2017

Conversation

naithar
Copy link
Contributor

@naithar naithar commented Jan 20, 2017

Implemented NSCoding protocol and isEqual to match macOS Foundation.

@parkera
Copy link
Contributor

parkera commented Jan 23, 2017

Hm, the darwin one encodes this as a C array of 6 big-endian floats.

@naithar
Copy link
Contributor Author

naithar commented Jan 25, 2017 •
edited
Loading

So should it encode a UnsafePointer<UInt> or just and array like [UInt]?

@parkera
Copy link
Contributor

parkera commented Jan 26, 2017

UnsafePointer<Float> I think.

@naithar
Copy link
Contributor Author

naithar commented Jan 27, 2017 •
edited
Loading

@parkera please review. Not sure it's a right implementation, but i found no other way to encode UnsafePointer<Float> or [Float].

@parkera
Copy link
Contributor

parkera commented Jan 30, 2017

Sure, let's give this a shot.

@parkera
Copy link
Contributor

parkera commented Jan 30, 2017

@swift-ci please test and merge

@parkera
Copy link
Contributor

parkera commented Feb 1, 2017 

TestFoundation/TestNSAffineTransform.swift:361: error: TestNSAffineTransform.test_NSCoding : XCTAssertEqual failed: ("<NSAffineTransform: 0x0000000001c704b0>") is not equal to ("<NSAffineTransform: 0x0000000001c7e9c0>") - Archived then unarchived `NSAffineTransform` must be equal.
Test Case 'TestNSAffineTransform.test_NSCoding' failed (0.004 seconds)

@naithar
Copy link
Contributor Author

naithar commented Feb 1, 2017

@parkera please review.

@parkera
Copy link
Contributor

parkera commented Feb 1, 2017

@swift-ci please test

@naithar
Copy link
Contributor Author

naithar commented Feb 2, 2017

@parkera if i understand correctly this test job (617) performed without errors.

@parkera
Copy link
Contributor

parkera commented Feb 2, 2017

Great!

@parkera
Copy link
Contributor

parkera commented Feb 2, 2017

@swift-ci test and merge

@swift-ci swift-ci merged commit 01ffe57 into swiftlang:master Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@naithar @parkera @swift-ci