[NSScanner] Fix a bug in the initialization of _NSStringBuffer that makes NSScanner unable to find any number #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…akes NSScanner unable to find any number. After writing a simple test case for NSScanner, I found that NSScanner always returns 0 when scanning numbers. The problem is in _NSStringBuffer's init function, `curChar` was assigned to `buffer[0]` before `buffer` gets characters from scanned string. Changing `curChar` to a optional variable and assign it to `buffer[0]` after buffer got all characters from scanned string fixed this.
|
Once this is merged, e1c253f should be reverted since those tests should then pass. |
|
good catch! looks good to me |
phausler
added a commit
that referenced
this pull request
Dec 8, 2015
[NSScanner] Fix a bug in the initialization of _NSStringBuffer that makes NSScanner unable to find any number
|
for some reason the NSRange one is still failing for me likely we have another bug lurking around |
atrick
pushed a commit
to atrick/swift-corelibs-foundation
that referenced
this pull request
Jan 12, 2021
[swiftpm] Statically link to libSwiftPM
kateinoigakukun
pushed a commit
to kateinoigakukun/swift-corelibs-foundation
that referenced
this pull request
Apr 29, 2021
Disable swift-driver while investigating several test failures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied from commit message:
After writing a simple test case for
NSScanner, I found thatNSScanneralways returns 0 when scanning numbers. The problem is in_NSStringBuffer's init function,curCharwas assigned tobuffer[0]beforebuffergets characters from scanned string. ChangingcurCharto an optional variable and assign it tobuffer[0]afterbuffergot all characters from scanned string fixed this.