[NSString] Add implementation of intValue and tests #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -457,7 +457,10 @@ extension NSString { | |||
|
|
|||
| public var intValue: Int32 { | |||
| get { | |||
| NSUnimplemented() | |||
| let scanner = NSScanner(string: _swiftObject) | |||
There was a problem hiding this comment.
with the experimental API currently implemented, this could just be one line: return NSScanner(string: _swiftObject).scanInt() ?? 0
There was a problem hiding this comment.
Thank you! I'm rebasing this and #86 now.
|
Perhaps add a test to validate the 0/failing path? |
|
@hartbit I think there is no need since |
|
I still think this is useful. You never know when someone in the future might change the implementation of the two methods independently. |
|
Will add more tests in another PR. |
atrick
pushed a commit
to atrick/swift-corelibs-foundation
that referenced
this pull request
Jan 12, 2021
Undo optimisim around requiring clangd during testing
kateinoigakukun
pushed a commit
to kateinoigakukun/swift-corelibs-foundation
that referenced
this pull request
Apr 29, 2021
…and-python3 Update the linux_load_command.py to support python3
kateinoigakukun
pushed a commit
to kateinoigakukun/swift-corelibs-foundation
that referenced
this pull request
Oct 11, 2023
[pull] swiftwasm from master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.