[gardening] Prefer Array(seq) over seq.map { $0 }
#867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@ikesyo I'm just curious if there a reason (performance or only elegance?) why we should prefer |
|
@pushkarnk I think that the former would/should be more efficient and the intent would be clearer (and also the latter looks a bit weird to me). See also an issue on SwiftLint project: realm/SwiftLint#1271. |
|
For the files that are also part of the overlay, let's also raise a PR there to make the same changes. |
|
Submitted swiftlang/swift#7243. |
|
LGTM |
|
@swift-ci test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.