[gardening]Remove commented code from URLSession #884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pushkarnk
changed the title
pushkarnk
reviewed
Feb 17, 2017
| // // Scale and clamp such that the range 0->1 ends up 1->256 | ||
| // let w = 1 + max(0, min(255, Int(round(weight * 255)))) | ||
| // try! CFURLSession_easy_setopt_long(rawHandle, CFURLSessionOptionPIPEWAIT, w).asError() | ||
| //} |
There was a problem hiding this comment.
May make sense to document what the CURLOPT_PIPEWAIT option helps achieve here ..
There was a problem hiding this comment.
Addressed suggested changes.
pushkarnk
reviewed
Feb 17, 2017
| //easyHandle.set(waitForPipeliningAndMultiplexing: true) | ||
| //easyHandle.set(streamWeight: priority) | ||
| //TODO: The CURLOPT_PIPEDWAIT option is unavailable on Ubuntu 14.04 (libcurl 7.36) | ||
| //TODO: Introduce something like an #if, if we want to set them here |
There was a problem hiding this comment.
May make sense to document what the CURLOPT_PIPEWAIT option helps achieve here ..
pushkarnk
reviewed
Feb 17, 2017
| @@ -167,9 +167,6 @@ extension _EasyHandle { | |||
| try! CFURLSession_easy_setopt_long(rawHandle, CFURLSessionOptionPROTOCOLS, protocols).asError() | |||
| try! CFURLSession_easy_setopt_long(rawHandle, CFURLSessionOptionREDIR_PROTOCOLS, protocols).asError() | |||
| //TODO: Added in libcurl 7.45.0 | |||
| // "https".withCString { | |||
| // try! CFURLSession_easy_setopt_ptr(rawHandle, CFURLSessionOptionDEFAULT_PROTOCOL, UnsafeMutablePointer($0)).asError() | |||
| //} | |||
| } | |||
There was a problem hiding this comment.
Can we document, in a comment, what this code accomplished?
pushkarnk
reviewed
Feb 23, 2017
| // try! CFURLSession_easy_setopt_ptr(rawHandle, CFURLSessionOptionDEFAULT_PROTOCOL, UnsafeMutablePointer($0)).asError() | ||
| //} | ||
| //TODO: Set default protocol for schemeless URLs | ||
| //CURLOPT_ DEFAULT_PROTOCOL available only in libcurl 7.45.0 |
There was a problem hiding this comment.
Nit: please remove the space after CURLOPT_
Changes in TODO
nethraravindran
commented
Feb 23, 2017
| // // Scale and clamp such that the range 0->1 ends up 1->256 | ||
| // let w = 1 + max(0, min(255, Int(round(weight * 255)))) | ||
| // try! CFURLSession_easy_setopt_long(rawHandle, CFURLSessionOptionPIPEWAIT, w).asError() | ||
| //} |
There was a problem hiding this comment.
Addressed suggested changes.
|
Cleaned up the commented code and addressed the changes |
|
@swift-ci please test and merge |
1 similar comment
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.