Enable URLSession tests in TestFoundation #895
Conversation
|
@swift-ci please test |
|
Yah, let's make sure this passes at least once then re-enable it for good. If it starts failing intermittently again we can re-disable it. |
|
The only annoying thing about this test is that when run on Darwin the triggering of running the HTTP server (that is fired up to test the client) invokes the macOS firewall asking if you want to allow/deny connections. Can we make it conditional so that it doesn't run when kicked off from a desktop build in some way? |
|
Unrelated failure. Re-triggering test. @swift-ci please test |
|
@alblue For that, we'd need to figure out how to disable the firewall in code. Btw, I came across a command that can enable/disable the firewall here: http://krypted.com/mac-os-x/command-line-alf-on-mac-os-x/ |
|
Or we could just not run the test inside Xcode?
Sent from my iPhone 📱
… On 28 Feb 2017, at 06:28, Pushkar N Kulkarni ***@***.***> wrote:
@alblue For that, we'd need to figure out how to disable the firewall in code. Btw, I came across a command that can enable/disable the firewall here: http://krypted.com/mac-os-x/command-line-alf-on-mac-os-x/
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
I think that if tests will be disabled for XCode, there should be at least some notification that they are disabled, since Also, using commands from the link didn't give any results on disabling/enabling firewall, but maybe it's just me. |
|
I think we could continue the discussion around the proposal for disabling URLSession tests in Xcode over the mailing list. |
|
@swift-ci please test and merge |
URLSessions tests had been disabled because of a libkqueue failure seen in CI. See: https://bugs.swift.org/browse/SR-3464
Given that we've done away with libkqueue in Dispatch and SR-3464 is no longer relevant, can we re-enable the URLSession tests in TestFoundation?
cc @gparker42