[NSURL] Implementation of '.checkResourceIsReachable' #904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
March 3, 2017 11:42
…ourceIsReachableAndReturnError' for 'NSURL' to match Darwin's Foundation. 'NSURL' does not throw on darwin by sets the error pointer that is passed in parameter.
Use correct initializer in test
naithar
force-pushed
the
nsurl-checkReachable
branch
from
86e26ee to
086d130
Compare
parkera
reviewed
Mar 5, 2017
Foundation/NSURL.swift
Outdated
| @@ -610,8 +610,28 @@ open class NSURL : NSObject, NSSecureCoding, NSCopying { | |||
| */ | |||
| /// - Experiment: This is a draft API currently under consideration for official import into Foundation as a suitable alternative | |||
| /// - Note: Since this API is under consideration it may be either removed or revised in the near future | |||
| open func checkResourceIsReachable() throws -> Bool { | |||
| NSUnimplemented() | |||
| open func checkResourceIsReachableAndReturnError(_ error: UnsafeMutablePointer<NSError?>?) -> Bool { | |||
There was a problem hiding this comment.
Did you put back the error argument here for compatibility with Darwin? There it's an autoreleased error, which we don't have on Linux. For this method I'm ok with the divergent API for now.
There was a problem hiding this comment.
Yes, I did it for compatibility with Darwin. I didn't know about the issue (i guess i've just missed it). I'll revert this change.
…ceIsReachable' with throw as Linux does not support Autoreleasing pointers
|
Updated |
|
@swift-ci please test and merge |
|
"ninja: error: unknown target 'swift-benchmark-linux-x86_64" |
|
@shahmishal @erg do you know what that error means? |
|
This PR should fix this issue swiftlang/swift#7931 |
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented and renamed method for
NSURLto match Darwin's version.Added method
. checkResourceIsReachabletoURLthat matches Darwin's Foundation.