Fix bug [SR-4391]: index check should be || instead of &&
#926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test
Sent from my iPhone 📱
… On 29 Mar 2017, at 08:08, Richard Wei ***@***.***> wrote:
You can view, comment on, or merge this pull request online at:
#926
Commit Summary
Fix bug [SR-4391]: index check should be `||` instead of `&&`
File Changes
M Foundation/NSOrderedSet.swift (2)
Patch Links:
https://github.com/apple/swift-corelibs-foundation/pull/926.patch
https://github.com/apple/swift-corelibs-foundation/pull/926.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@swift-ci please test |
|
Can we get a new test case? Obviously we are lacking in this area. :) |
|
@parkera The case was already covered by |
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug in NSOrderedSet index check