Remove blocks runtime when building with libdispatch #938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The blocks runtime is already contained in libdispatch so removing this 2nd copy from libFoundation removes duplicate code. - The libdispatch version is also slightly more optimal as it doesnt compile functions only needed when HAVE_OBJC is defined.
|
@swift-ci please test |
|
@parkera Can this be merged now? |
|
Sure; let me kick off another test since it's been a while. |
|
@swift-ci test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The blocks runtime is already contained in libdispatch
so removing this 2nd copy from libFoundation removes duplicate
code.
The libdispatch version is also slightly more optimal as it
doesnt compile functions only needed when HAVE_OBJC is defined.
This is also needed to avoid duplicate symbol errors when statically linking Foundation using #873
Also see discussion about blocks runtime in #874
An alternative, which I did test, is just to remove
data.candruntime.calthough this meanslibdispatchalways has to be linked in and Im not sure if it is guaranteed to always be a dependancy.