Move dispatch_concur and dispatch_readsync to the XFAIL list #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the following tests to the XFAIL list as they fail in the Swift CI environment:
dispatch_concur: fails every timedispatch_readsync: fails around 50% of the timeThe failures can be recreated on a sufficiently large (24 CPU+) machine locally, so we can debug offline and re-enable the tests once we've either fixed the test or an underlying issue in dispatch/kqueue/pwq
Disabling the tests should allows us to get the CI environment running clean, and moving towards enabling higher level testing by integrating into Foundation.
Note that
dispatch_concurstill fails for me locally with PR #117 applied, although that patch certainly causes many less components of the test to fail.