Fix Swift dispatch time comparisons #182
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilyball
force-pushed
the
dispatch_time_comparisons
branch
from
6b05b7e to
25876e8
Compare
|
@mwwa please also review swiftlang/swift#5078 (which I cannot assign to you for some reason) |
|
once done, we should probably also clone this for the swift-3 branch (in both repos) |
|
The other PR has now been merged. This one still needs to be reviewed. |
|
@swift-ci please test |
|
This was merged into apple/swift many months ago. Is the failed test here the only thing holding this up? The details link is a 404 so I can't see what went wrong. |
Let's at least fix that much @swift-ci please test |
|
Looks like it passed this time. |
|
Looks like this change was made during an overlay sync up. Thanks for the original! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
<comparisons onDispatchWallTimenot crash.<comparisons againstDispatchTime.distantFutureandDispatchWallTime.distantFuturebehave as expected.This is a port of swiftlang/swift#5078, but without the tests because I don't see any Swift tests in this repo.