consider affinity when computing active cpus on Linux #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why is that better? |
|
It gets the right answer if the program is being run under numactl with a restricted cpu set. sysconf doesn't consider scheduler affinity. |
|
I see, makes sense, could you please add a comment above to explain this shortly in the .c file ? because someone is bound to wonder at some point. |
If pthread_getaffinity_np is available, then use the cpuset of the current thread to determine the number of active cpus.
dgrove-oss
force-pushed
the
hwconfig-respect-affinity
branch
from
7aeabe5 to
e59638d
Compare
|
good point; added a comment & squashed commit. |
das
pushed a commit
that referenced
this pull request
Feb 21, 2017
consider affinity when computing active cpus on Linux Signed-off-by: Daniel A. Steffen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If pthread_getaffinity_np is available, then use the cpuset
of the current thread to determine the number of active cpus.