Loosen test deadlines to reduce spurious failures in Swift CI #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add build flag that defaults to true when building with Swift support enabled (like when in Swift CI) that relaxes the passing criteria for timing-sensitive dispatch tests. We continue to see occasional spurious failures of dispatch tests in the Swift CI caused by test machine load; this is an attempt to reduce the frequency of load-induced failures without removing the test cases entirely.
|
@swift-ci please test |
MadCoder
approved these changes
May 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add build flag that defaults to true when building
with Swift support enabled (like when in Swift CI)
that relaxes the passing criteria for timing-sensitive
dispatch tests. We continue to see occasional spurious
failures of dispatch tests in the Swift CI caused by
test machine load; this is an attempt to reduce the frequency
of load-induced failures without removing the test cases
entirely.